Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nil to be used as a default_currency #1095

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sirwolfgang
Copy link

This is a part of fixing the RubyMoney/money-rails#697

Copy link

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an entry to the CHANGELOG as well? 🙏🏻

lib/money/money.rb Outdated Show resolved Hide resolved
lib/money/money.rb Outdated Show resolved Hide resolved
@sirwolfgang
Copy link
Author

@sunny Yeah my bad, updated.

@sirwolfgang sirwolfgang requested a review from sunny May 16, 2024 08:09
Copy link

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mediafinger
Copy link

We would love to see this included as well. A default currency is a hard no for our use case.

Is there any chance to get this merged anytime soon?

@mhenrixon
Copy link

Any chance this can get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants