Replace deprecated method and add Ethereum (ETH) to non-ISO currencies #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please rebase and I will merge |
|
020c091 should not be needed anymore |
stebo
suggested changes
Mar 15, 2024
config/currency_non_iso.json
Outdated
| "symbol": "Ξ", | ||
| "alternate_symbols": [], | ||
| "subunit": "Wei", | ||
| "subunit_to_unit": 100000000, |
There was a problem hiding this comment.
ETH to WEI is 1000000000000000000
Suggested change
| "subunit_to_unit": 100000000, | |
| "subunit_to_unit": 1000000000000000000, |
|
still need a rebase before we can consider merging. |
douglas-franca
force-pushed
the
douglas/add-eth-currency
branch
2 times, most recently
from
6a63723 to
82a6cc2
Compare
semmons99
previously approved these changes
Apr 15, 2024
|
failing tests 😞 |
douglas-franca
force-pushed
the
douglas/add-eth-currency
branch
from
82a6cc2 to
8d64616
Compare
|
Hey @douglas-franca would you mind rebasing with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request include one change: