Add ignoreUnavailable and defaultValue for MetricsAPI scaler #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use kedacore image for mssql e2e test Signed-off-by: Steven Chau <[email protected]> * Refactor MSSql Scaler to use kedacore test tools mssql image Signed-off-by: Steven Chau <[email protected]> * Move readme description to other section Signed-off-by: Steven Chau <[email protected]> * Remove empty row Co-authored-by: Rick Brouwer <[email protected]> Signed-off-by: SC <[email protected]> --------- Signed-off-by: Steven Chau <[email protected]> Signed-off-by: SC <[email protected]> Co-authored-by: Rick Brouwer <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]>
…sult (kedacore#6906) * (fix): `sumologic scaler`: don't complain if query results in zero messages Signed-off-by: mittalvaibhav1 <[email protected]> * (fix): `sumologic scaler`: Update tests and making polling interval configureable Signed-off-by: mittalvaibhav1 <[email protected]> * (fix): Increase sumologic scaler e2e pollingInterval Signed-off-by: mittalvaibhav1 <[email protected]> * (fix): Add rate-limiting handling Signed-off-by: mittalvaibhavs <[email protected]> * (fix): tuning e2e Signed-off-by: mittalvaibhavs <[email protected]> * (fix): semgrep happy Signed-off-by: mittalvaibhav1 <[email protected]> * (fix): update changelog Signed-off-by: mittalvaibhav1 <[email protected]> * PR comments - removing changelog entry Co-authored-by: Rick Brouwer <[email protected]> Signed-off-by: Vaibhav Mittal <[email protected]> --------- Signed-off-by: mittalvaibhav1 <[email protected]> Signed-off-by: mittalvaibhavs <[email protected]> Signed-off-by: Vaibhav Mittal <[email protected]> Co-authored-by: Rick Brouwer <[email protected]>
* refactor: rename temporal scaler files for consistency Renames the temporal scaler files to follow the convention used by other scalers in the project. - -> - -> - -> Signed-off-by: Aniruddh Chaturvedi <[email protected]> * address feedback Signed-off-by: Aniruddh Chaturvedi <[email protected]> --------- Signed-off-by: Aniruddh Chaturvedi <[email protected]> Signed-off-by: Aniruddh Chaturvedi <[email protected]>
Signed-off-by: Rick Brouwer <[email protected]>
…ns (kedacore#6922) Signed-off-by: Rick Brouwer <[email protected]>
…mock servers (kedacore#6914) * fix: eliminate race conditions in NSQ scaler tests by using separate mock servers Signed-off-by: Rick Brouwer <[email protected]> * update feedback Signed-off-by: Rick Brouwer <[email protected]> --------- Signed-off-by: Rick Brouwer <[email protected]>
…ject controller test (kedacore#6924) Signed-off-by: Rick Brouwer <[email protected]>
robinderooij-rl
force-pushed
the
feature/metrics-api-ignore-null
branch
from
d5bdba1 to
0aa8729
Compare
The options `ignoreUnavailable` and `defaultValue` are added to the metrics API scaler. A potential use case for this is a deployment that uses multiple scalers and can also scale to zero. In this case, you might want to use the metrics API to prevent the deployment from being downscaled. Signed-off-by: Robin de Rooij <[email protected]>
robinderooij-rl
force-pushed
the
feature/metrics-api-ignore-null
branch
from
a3872d5 to
161ccc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ignoreUnavailabletrue