Fix CI to build and push the image #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the broken v0.9 of controller-gen because it causes a segfault when running `make install`
I don't like formatting :(
It is mentioned in a comment in the code itself but because of the discrepency between the fields in the EndpointMonitor CR and the Statuscake API it is not immediately clear how to compare an old monitor with an updated monitor. The way I have elected to check this is to use the TestTags field to include some kind of identifier that should be updated on any change. So if the tags have changed then the monitor should be updated.
robinderooij-rl
requested changes
Oct 24, 2024
robinderooij-rl
left a comment
robinderooij-rl
left a comment
There was a problem hiding this comment.
We have version control for a reason 😄 I think we should just delete the commented lines
Base automatically changed from
feature/impl-equals-func-statuscake
to
master
October 24, 2024 09:30
matthijswolters-rl
force-pushed
the
feature/fix-docker-image-ci
branch
from
8a7e6eb to
181ada2
Compare
robinderooij-rl
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hacky fix to push our own image our own image registry. Once the changes have been upstreamed this can be reverted.