fix stance icon not updating when selecting units

RoosterDragon · Mar 28, 2023 · 9e08176 · 9e08176
1 parent 378f66a
commit 9e08176
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/OpenRA.Mods.Common/Scripting/Properties/GeneralProperties.cs b/OpenRA.Mods.Common/Scripting/Properties/GeneralProperties.cs
@@ -175,7 +175,6 @@ public string Stance
 				if (!Enum<UnitStance>.TryParse(value, true, out var stance))
 					throw new LuaException($"Unknown stance type '{value}'");
 
-				autotarget.PredictedStance = stance;
 				autotarget.SetStance(Self, stance);
 			}
 		}

diff --git a/OpenRA.Mods.Common/Traits/AutoTarget.cs b/OpenRA.Mods.Common/Traits/AutoTarget.cs
@@ -153,7 +153,7 @@ public void SetStance(Actor self, UnitStance value)
 				return;
 
 			var oldStance = Stance;
-			Stance = value;
+			Stance = PredictedStance = value;
 			ApplyStanceCondition(self);
 
 			foreach (var nsc in notifyStanceChanged)
@@ -204,8 +204,7 @@ protected override void Created(Actor self)
 
 		void INotifyOwnerChanged.OnOwnerChanged(Actor self, Player oldOwner, Player newOwner)
 		{
-			PredictedStance = self.Owner.IsBot || !self.Owner.Playable ? Info.InitialStanceAI : Info.InitialStance;
-			SetStance(self, PredictedStance);
+			SetStance(self, self.Owner.IsBot || !self.Owner.Playable ? Info.InitialStanceAI : Info.InitialStance);
 		}
 
 		void IResolveOrder.ResolveOrder(Actor self, Order order)