Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#78: Added new PhpUnit extension and event subscriber to support PhpUnit v10 and deleted redundant PushDocumentation artisan command #79

Merged
merged 15 commits into from
Nov 13, 2023
Merged

#78: Added new PhpUnit extension and event subscriber to support PhpUnit v10 and deleted redundant PushDocumentation artisan command #79

merged 15 commits into from
Nov 13, 2023

Conversation

vitgrams
Copy link
Contributor

@vitgrams vitgrams commented Mar 4, 2023

…

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vitgrams
feat: added new PhpUnit extension and event subscriber to support Php…
45fbecf 
…Unit v10 and deleted redundant PushDocumentation artisan command
@vitgrams vitgrams force-pushed the 78_add_new_php_event_system_support branch 6 times, most recently from 4ccca81 to 45fbecf Compare March 5, 2023 13:20
@vitgrams vitgrams force-pushed the 78_add_new_php_event_system_support branch 3 times, most recently from a81ff93 to dc737ae Compare March 5, 2023 15:18
@vitgrams vitgrams force-pushed the 78_add_new_php_event_system_support branch 10 times, most recently from aa21904 to 836bc25 Compare March 7, 2023 05:02
@vitgrams
Copy link
Contributor Author

vitgrams commented Mar 7, 2023 •
edited
Loading

@DenTray Implemented for phpUnit v 10. These changes will break backward compatibility. Could you please review this code?

@vitgrams vitgrams requested a review from DenTray March 7, 2023 07:46
@DenTray DenTray requested a review from NikitaYakovlev March 7, 2023 10:00
@vitgrams
Copy link
Contributor Author

@DenTray Increased code coverage by unit tests. I can't write test method for PhpUnit extension class because notify() method has mandatory event argument which is the object of the final class.

@vitgrams vitgrams assigned DenTray and unassigned vitgrams Mar 14, 2023
@vitgrams
Copy link
Contributor Author

vitgrams commented Mar 15, 2023 •
edited
Loading

@DenTray Please note that the changes from 78_save_temp_doc_in_file_for_local_and_storage_drivers branch have been merged into current branch because rebase operation is not allowed here.

@DenTray
Copy link
Collaborator

DenTray commented Mar 22, 2023

@vitgrams could you please resolve conflicts

@DenTray DenTray assigned vitgrams and unassigned DenTray Mar 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vitgrams
Copy link
Contributor Author

@DenTray Conflicts have been resolved.

@vitgrams vitgrams assigned DenTray and unassigned vitgrams Mar 22, 2023
@DenTray
Copy link
Collaborator

DenTray commented Jun 20, 2023

required new major version, waiting for stable master

@DenTray
Copy link
Collaborator

DenTray commented Nov 7, 2023 •
edited
Loading

@Goodmain could you please resolve conflicts

@DenTray DenTray assigned Goodmain and unassigned DenTray Nov 7, 2023
@DenTray DenTray added this to the 3.0 milestone Nov 7, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Goodmain
Copy link
Contributor

Goodmain commented Nov 7, 2023 •
edited
Loading

@DenTray Done, I resolved conflicts

@Goodmain Goodmain requested a review from DenTray November 7, 2023 18:52
@DenTray DenTray merged commit a440f4f into master Nov 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikitaYakovlev NikitaYakovlev NikitaYakovlev approved these changes

@DenTray DenTray DenTray approved these changes

Assignees

@Goodmain Goodmain

Labels
state: code review type: feature
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vitgrams @DenTray @Goodmain @NikitaYakovlev