Chronicles of Darkness: Don't overwrite defense setting each time the sheet is opened

[ClaytonAstrom]

Submission Checklist

Required

• The pull request title clearly contains the name of the sheet I am editing.
• The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
• The pull request makes changes to files in only one sub-folder.
• The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

• The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

• The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

• The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

• I have followed the Character Sheets Standards when building this sheet.

• I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
• This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
• This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

From what I can tell, every single time the character sheet is opened it will revert a character's defense setting to the template's default rather than any value they had previously selected. I know this is a little duplicative in terms of code but I figured it would avoid a major refactor.

I believe this bug is also present in CofD by Roll20 as well:
https://github.com/Roll20/roll20-character-sheets/blob/master/Chronicles%20of%20Darkness%20by%20Roll20/CofD%20by%20Roll20.html#L2371

I don't have a pro account so I wasn't able to test this in the sandbox.

[roll20deploy]

Character Sheet Info Roll20 Internal Use only.

[NorWhal]

Hey @ClaytonAstrom!

The "by Roll20" code was moved to a different repository some time ago, but I'll go and check if this is happening there. I'm going to give @AdolfoDomingues a courtesy window of two weeks to test this and review it since they're the code owner and you were not able to test this.

Thanks,
Nora

[AdolfoDomingues]

Hello @ClaytonAstrom !
This bug of the defence reverting back to the default has been bugging me off for a while but I didn't know how to fix it. Thank you very much for helping! =D
I'll test the sheets once your update is rolled in!

Also, if you know how to mess with the code of the character sheets, something else that I always wanted to do but never managed to was to make that clicking to make a "route" roll would be separated from rolling the 9-again and 8-again. Also to automatically roll chance-dies when the dicepool becomes 0 or less. If you know how to do it, I would love some help!

Thank you very much, seeing your commit sparkled another wave of interest in me to improve the sheets!