New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to new sdk #42

Open

ggazzo wants to merge 1 commit into main from chore/new-sdk

+418 −102

Member

ggazzo commented Jul 17, 2023

No description provided.


          migrate to new sdk

aceefef

github-advanced-security bot found potential problems

View reviewed changes

src/client/Omnichannel.ts

@@ @@ -157,7 +159,7 @@ @@
               			end({ status: 'success' });
               			endAction({ status: 'success' });
               		} catch (e) {
-              			console.error('error open room', { uid: this.client.userId, rid }, e);
+              			console.error('error open room', { uid: this.client.account.uid, rid }, e);

Check failure

Code scanning / CodeQL

Insecure randomness

This uses a cryptographically insecure random number generated at [Math.random()](1) in a security context.

ggazzo marked this pull request as ready for review

July 17, 2023 18:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet