Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tolerations in all deployments and pods #95

Merged
merged 4 commits into from
May 8, 2024

Conversation

LaloLoop
Copy link
Contributor

@LaloLoop LaloLoop commented Apr 4, 2023

Closes In the Helm chart toleration missed #89

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2023

CLA assistant check
All committers have signed the CLA.

@debdutdeb debdutdeb force-pushed the master branch 2 times, most recently from 92545cc to 07f6c3a Compare July 19, 2023 18:11
@AlexGidman
Copy link

@LaloLoop were there any issues with having this merged? This is something we're looking at for an enterprise deployment, we really don't want to have to fork the helm chart!

@LaloLoop
Copy link
Contributor Author

Hi @AlexGidman , we have yet to get any feedback from the RocketChat team.
Hello @debdutdeb, @geekgonecrazy . Sorry to tag you directly, I'm adding you as I found your usernames in recent PR reviews/merges. Any chance of getting a review here?
Thanks!

@debdutdeb
Copy link
Member

Could this key be per-deployment and not common for all?

Maybe there could be a global key that is common, then per-deployment to override each. I see the value in not having to repeat for all deployments.

@AlexGidman
Copy link

AlexGidman commented Apr 30, 2024

Could this key be per-deployment and not common for all?

Maybe there could be a global key that is common, then per-deployment to override each. I see the value in not having to repeat for all deployments.

I'll admit that I don't know all situations where tolerations may be applicable; in our case, the ability to apply tolerations 'globally' is a lot cleaner and sufficient for our purposes.

@debdutdeb debdutdeb merged commit c494c79 into RocketChat:master May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants