Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuselage): Using Pre Wrap For System Message #891

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nishant23122000
Copy link

@nishant23122000 nishant23122000 commented Nov 4, 2022

Proposed changes (including videos or screenshots)

Before :

Screenshot 2022-11-11 at 12 33 13 AM

After :

Screenshot 2022-11-11 at 12 33 55 AM

reason of change : RocketChat/Rocket.Chat#27080

Issue(s)

Further comments

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dougfabris dougfabris changed the title Using Pre Wrap For System Message fix(fuselage): Using Pre Wrap For System Message Nov 8, 2022
@gabriellsh
Copy link
Member

Can you add screenshots so we now how it changed visually? Also a description so we could understand the issue better would help. Thanks!

@nishant23122000
Copy link
Author

Can you add screenshots so we now how it changed visually? Also a description so we could understand the issue better would help. Thanks!

Done check now

@gabriellsh
Copy link
Member

Hey @nishant23122000 ! I'll be checking with design to see if this is the desired UI/UX for this. If we're all in agreement, I'll review the code and merge this.

@jsdgdo
Copy link

jsdgdo commented Nov 14, 2022

Hello @nishant23122000, José from Rocket.Chat's design team here. I was wondering what prompted your need to work on longer system messages, in our experience they usually are no longer than 4 or 5 words. So we don't actually see a need for this particular improvement.

Either way I'm excited to find a solution to this problem in the coming releases, but this particular one doesn't agree with the spacing standards we set up for the platform. Hope you understand.

@nishant23122000
Copy link
Author

If words are less than 4 or 5 then it makes sense to don't do these changes.

but I think the agent can write long sentences also in some cases.

@dudanogueira
Copy link

The UX problem, IMHO, is that the receiving agent will not have access to that comment in full, which is usually very important for the chat handling.

Isn't there a way to allow that message to be shown, like on mouse hover?

@dougfabris dougfabris changed the base branch from develop to main September 13, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants