-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fuselage): Using Pre Wrap For System Message #891
base: main
Are you sure you want to change the base?
fix(fuselage): Using Pre Wrap For System Message #891
Conversation
|
Can you add screenshots so we now how it changed visually? Also a description so we could understand the issue better would help. Thanks! |
Done check now |
Hey @nishant23122000 ! I'll be checking with design to see if this is the desired UI/UX for this. If we're all in agreement, I'll review the code and merge this. |
Hello @nishant23122000, José from Rocket.Chat's design team here. I was wondering what prompted your need to work on longer system messages, in our experience they usually are no longer than 4 or 5 words. So we don't actually see a need for this particular improvement. Either way I'm excited to find a solution to this problem in the coming releases, but this particular one doesn't agree with the spacing standards we set up for the platform. Hope you understand. |
If words are less than 4 or 5 then it makes sense to don't do these changes. but I think the agent can write long sentences also in some cases. |
The UX problem, IMHO, is that the receiving agent will not have access to that comment in full, which is usually very important for the chat handling. Isn't there a way to allow that message to be shown, like on mouse hover? |
77be55a
to
a97c7f0
Compare
Proposed changes (including videos or screenshots)
Before :
After :
reason of change : RocketChat/Rocket.Chat#27080
Issue(s)
Further comments