Add atlasScheduledAutoscaling (SRE-720) #18
Draft
+324
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debdutdeb
reviewed
Nov 1, 2024
| LowTier string `json:"lowTier,omitempty"` | ||
|
|
||
| // The maximum tier the cluster can scale up to. | ||
| // +kubebuilder:validation:Enum=M0;M2;M5;M10;M20;M30;M40;M50;M60;M80;M140;M200;M300;M400;M500;M700;M900;M1000 |
There was a problem hiding this comment.
should shared tiers be listed as valid scale downs or scale ups? likely we don't want to scale down so much or up, we could avoid mistakes like typos by not having them in validation.
There was a problem hiding this comment.
Yeah, doesn't make sense to have anything below M10 there, and I'll cap it at M200. That way we don't acidentally typo in an M400 and go bankrupt in a month.
debdutdeb
reviewed
Nov 1, 2024
|
|
||
| // Cron expression for the time the cluster should be scaled down. | ||
| // +kubebuilder:default="0 20 * * 1-5" | ||
| ScaleDownExpression string `json:"scaleDownExpression,omitempty"` |
There was a problem hiding this comment.
Suggested change
| ScaleDownExpression string `json:"scaleDownExpression,omitempty"` | |
| ScaleDownCronExpression string `json:"scaleDownCronExpression,omitempty"` |
debdutdeb
reviewed
Nov 1, 2024
|
|
||
| // Cron expression for the time the cluster should be scaled up. | ||
| // +kubebuilder:default="0 6 * * 1-5" | ||
| ScaleUpExpression string `json:"scaleUpExpression,omitempty"` |
There was a problem hiding this comment.
Suggested change
| ScaleUpExpression string `json:"scaleUpExpression,omitempty"` | |
| ScaleUpCronExpression string `json:"scaleUpCronExpression,omitempty"` |
being more verbose as expression can mean plain texts too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.