Skip to content

Conversation

KevLehman
Copy link
Member

@KevLehman KevLehman commented Sep 1, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-317

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Sep 1, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 1, 2025

⚠️ No Changeset found

Latest commit: 000cd65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.35%. Comparing base (5af5203) to head (000cd65).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36854   +/-   ##
========================================
  Coverage    66.35%   66.35%           
========================================
  Files         3324     3324           
  Lines       111332   111339    +7     
  Branches     21088    21089    +1     
========================================
+ Hits         73874    73882    +8     
+ Misses       34769    34766    -3     
- Partials      2689     2691    +2     
Flag Coverage Δ
e2e 57.66% <ø> (ø)
unit 71.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman marked this pull request as ready for review September 3, 2025 13:41
@KevLehman KevLehman requested a review from a team as a code owner September 3, 2025 13:41
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Sep 3, 2025
@KevLehman KevLehman added this to the 7.11.0 milestone Sep 3, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 3, 2025
@kodiakhq kodiakhq bot merged commit 1e74e31 into develop Sep 3, 2025
87 checks passed
@kodiakhq kodiakhq bot deleted the chore/queuemetricsprom branch September 3, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants