-
Notifications
You must be signed in to change notification settings - Fork 12.1k
chore!: Adds deprecation warning and serves new chart data endpoint #36845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
}); | ||
|
||
if (!chartData) { | ||
return API.v1.failure('No data available'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we should return a 400 with that message or an empty response like:
return API.v1.failure({
chartLabel: null,
dataLabels: [],
dataPoints: [],
});
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36845 +/- ##
===========================================
+ Coverage 66.23% 66.30% +0.07%
===========================================
Files 3303 3310 +7
Lines 111032 111356 +324
Branches 21048 21096 +48
===========================================
+ Hits 73537 73837 +300
- Misses 34811 34831 +20
- Partials 2684 2688 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
This PR adds a new deprecation warning for
livechat:getAnalyticsChartData
as well as adding a new endpoint to replace it.Issue(s)
CTZ-53
Steps to test or reproduce
Further comments