Skip to content

Conversation

lucas-a-pelegrino
Copy link
Member

@lucas-a-pelegrino lucas-a-pelegrino commented Sep 1, 2025

Proposed changes (including videos or screenshots)

This PR adds a new deprecation warning for livechat:getAnalyticsChartData as well as adding a new endpoint to replace it.

Issue(s)

CTZ-53

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Sep 1, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 1, 2025

⚠️ No Changeset found

Latest commit: c8a1862

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.11.0 milestone Sep 1, 2025
});

if (!chartData) {
return API.v1.failure('No data available');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should return a 400 with that message or an empty response like:

return API.v1.failure({
  chartLabel: null,
  dataLabels: [],
  dataPoints: [],
});

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.30%. Comparing base (0b5cdaf) to head (c8a1862).
⚠️ Report is 34 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36845      +/-   ##
===========================================
+ Coverage    66.23%   66.30%   +0.07%     
===========================================
  Files         3303     3310       +7     
  Lines       111032   111356     +324     
  Branches     21048    21096      +48     
===========================================
+ Hits         73537    73837     +300     
- Misses       34811    34831      +20     
- Partials      2684     2688       +4     
Flag Coverage Δ
unit 71.56% <50.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant