-
Notifications
You must be signed in to change notification settings - Fork 12.1k
Document slash command state transitions #36826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Document slash command state transitions #36826
Conversation
Co-authored-by: douglas.gubert <[email protected]>
Cursor Agent can help with this pull request. Just |
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
…nable Co-authored-by: douglas.gubert <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36826 +/- ##
===========================================
- Coverage 66.13% 65.11% -1.03%
===========================================
Files 3303 3114 -189
Lines 110998 108077 -2921
Branches 21051 20369 -682
===========================================
- Hits 73411 70371 -3040
- Misses 34912 35278 +366
+ Partials 2675 2428 -247
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
docs: Document slash command lifecycle in apps-engine
Proposed changes (including videos or screenshots)
This PR introduces a new markdown file (
slash-command-lifecycle-flowchart.md
) that documents the lifecycle of slash commands within the Rocket.Chat Apps Engine.The file includes:
AppActivationBridge
notifications are triggered during their lifecycle.isRegistered
,isEnabled
,isDisabled
) and ownership rules.This documentation aims to provide a clear understanding of how slash commands are managed and interact with the app lifecycle.
Issue(s)
N/A
Steps to test or reproduce
Review the
slash-command-lifecycle-flowchart.md
file to ensure clarity and accuracy of the documented lifecycle.Further comments
This documentation helps clarify the often complex process of slash command registration, enabling, disabling, and unregistration, which is tightly coupled with the app's lifecycle. It should be a valuable resource for app developers and maintainers.