Skip to content

Conversation

MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Aug 27, 2025

Proposed changes (including videos or screenshots)

Introduces the useCanEditCannedResponse in order to verify if the any of the possible permissions to create or edit a canned response and do not display the create button on the UI

Issue(s)

Steps to test or reproduce

  • Remove view-all-canned-responses, save-canned-responses and save-department-canned-responses from a role that has manage-livechat permission
  • Open the canned response context bar
  • The create or edit canned response button should be hidden

Further comments

SUP-837

Copy link
Contributor

dionisio-bot bot commented Aug 27, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 27, 2025

🦋 Changeset detected

Latest commit: 2272d2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.04%. Comparing base (e497d94) to head (2272d2a).
⚠️ Report is 50 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36814      +/-   ##
===========================================
- Coverage    66.12%   66.04%   -0.08%     
===========================================
  Files         3302     3335      +33     
  Lines       110951   113047    +2096     
  Branches     21044    21112      +68     
===========================================
+ Hits         73369    74665    +1296     
- Misses       34915    35691     +776     
- Partials      2667     2691      +24     
Flag Coverage Δ
e2e 57.66% <ø> (+0.41%) ⬆️
e2e-api 35.51% <ø> (-0.01%) ⬇️
unit 70.77% <90.24%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review August 28, 2025 16:46
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner August 28, 2025 16:46
@dougfabris dougfabris added this to the 7.11.0 milestone Sep 1, 2025
dougfabris
dougfabris previously approved these changes Sep 3, 2025
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Sep 3, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 3, 2025
dougfabris
dougfabris previously approved these changes Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants