-
Notifications
You must be signed in to change notification settings - Fork 12.1k
fix: canned responses contextual bar not using correct permissions #36814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 2272d2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36814 +/- ##
===========================================
- Coverage 66.12% 66.04% -0.08%
===========================================
Files 3302 3335 +33
Lines 110951 113047 +2096
Branches 21044 21112 +68
===========================================
+ Hits 73369 74665 +1296
- Misses 34915 35691 +776
- Partials 2667 2691 +24
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
...eteor/client/omnichannel/cannedResponses/contextualBar/CannedResponse/WrapCannedResponse.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes (including videos or screenshots)
Introduces the
useCanEditCannedResponse
in order to verify if the any of the possible permissions to create or edit a canned response and do not display the create button on the UIIssue(s)
Steps to test or reproduce
view-all-canned-responses
,save-canned-responses
andsave-department-canned-responses
from a role that hasmanage-livechat
permissionFurther comments
SUP-837