Skip to content

Conversation

jessicaschelly
Copy link
Member

@jessicaschelly jessicaschelly commented Aug 27, 2025

Proposed changes (including videos or screenshots)

Introduces end-to-end tests for LDAP authentication functionality with automated Docker-based test infrastructure.

New Files Added:

  • apps/meteor/tests/e2e/ldap.spec.ts - Main LDAP test suite with 3 test scenarios
  • apps/meteor/tests/e2e/containers/ldap/Dockerfile - OpenLDAP container setup
  • apps/meteor/tests/e2e/containers/ldap/docker-compose.yml - Container orchestration
  • apps/meteor/tests/e2e/containers/ldap/config/test_users.ldif - Test user data configuration

Modified Files:

  • apps/meteor/tests/e2e/fixtures/userStates.ts - Added ldapuser1 test state

Test Coverage:

  • Connection Test - Validates LDAP server connectivity via /ldap.testConnection
  • User Search Test - Tests user discovery via /ldap.testSearch
  • Authentication Test - Complete login flow with field mapping validation (uidusername, cnname, mailemail)

Issue(s)

QA-95

Steps to Reproduce

Expected results:

  • All 3 tests should pass (Connection, User Search, Login)
  • User should be created in Rocket.Chat with proper field mapping
  • Docker containers should start/stop cleanly

Further comments

  • Uses OpenLDAP 1.3.0 container with domain rcldap.com.br
  • Includes proper CI support with host.docker.internal for container networking
  • Automatic setup/teardown ensures test isolation
  • Foundation for future LDAP testing scenarios (group sync, SSL, role mapping)

Copy link
Contributor

dionisio-bot bot commented Aug 27, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 27, 2025

⚠️ No Changeset found

Latest commit: b8f856d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.15%. Comparing base (83eeed0) to head (b8f856d).
⚠️ Report is 38 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36810      +/-   ##
===========================================
+ Coverage    65.51%   66.15%   +0.64%     
===========================================
  Files         3152     3303     +151     
  Lines       106869   110991    +4122     
  Branches     20265    21058     +793     
===========================================
+ Hits         70010    73427    +3417     
- Misses       34257    34893     +636     
- Partials      2602     2671      +69     
Flag Coverage Δ
e2e 57.31% <ø> (+1.34%) ⬆️
unit 71.49% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jessicaschelly jessicaschelly marked this pull request as ready for review August 28, 2025 12:02
@jessicaschelly jessicaschelly requested a review from a team as a code owner August 28, 2025 12:02
@jessicaschelly jessicaschelly changed the title test: create automated tests for ldap test: create automated tests for ldap login Aug 28, 2025
@jessicaschelly jessicaschelly modified the milestones: 7.10.0, 7.11.0 Aug 28, 2025
@jessicaschelly jessicaschelly marked this pull request as draft August 28, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant