Skip to content

Conversation

MartinSchoeler
Copy link
Member

Proposed changes (including videos or screenshots)

Fixes this
Screenshot 2025-08-26 at 10 04 50
The parameters sent to the t function were not being translated themselves

Issue(s)

Steps to test or reproduce

  • Try to create an encrypted channel/team using any language other than english

Further comments

I've not added tests, since our translation mocks are not working with languages that are not english. I'll be investigating the issue on a separate PR

Copy link
Contributor

dionisio-bot bot commented Aug 26, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 26, 2025

🦋 Changeset detected

Latest commit: 987c83e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.32%. Comparing base (dc5b3d2) to head (987c83e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36799      +/-   ##
===========================================
+ Coverage    66.30%   66.32%   +0.01%     
===========================================
  Files         3328     3322       -6     
  Lines       111387   111281     -106     
  Branches     21124    21085      -39     
===========================================
- Hits         73858    73803      -55     
+ Misses       34830    34789      -41     
+ Partials      2699     2689      -10     
Flag Coverage Δ
e2e 57.63% <16.66%> (+0.02%) ⬆️
unit 71.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review August 26, 2025 18:09
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner August 26, 2025 18:09
Copy link
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint errors to solve...

@dougfabris dougfabris force-pushed the fix/missing-encryption-translation branch from 06b1904 to 987c83e Compare September 1, 2025 21:52
@dougfabris dougfabris added this to the 7.11.0 milestone Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants