-
Notifications
You must be signed in to change notification settings - Fork 12.1k
fix: missing room type translation on useEncryptedRoomDescription #36799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 987c83e The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36799 +/- ##
===========================================
+ Coverage 66.30% 66.32% +0.01%
===========================================
Files 3328 3322 -6
Lines 111387 111281 -106
Branches 21124 21085 -39
===========================================
- Hits 73858 73803 -55
+ Misses 34830 34789 -41
+ Partials 2699 2689 -10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint errors to solve...
06b1904
to
987c83e
Compare
Proposed changes (including videos or screenshots)
Fixes this

The parameters sent to the t function were not being translated themselves
Issue(s)
Steps to test or reproduce
Further comments
I've not added tests, since our translation mocks are not working with languages that are not english. I'll be investigating the issue on a separate PR