Skip to content

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 22, 2025

Proposed changes (including videos or screenshots)

Kapture 2025-09-01 at 17 03 04

Issue(s)

Steps to test or reproduce

Further comments

CORE-1315

Copy link
Contributor

dionisio-bot bot commented Aug 22, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 22, 2025

🦋 Changeset detected

Latest commit: 52b50e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/queue-worker Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/http-router Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence-service Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris force-pushed the feat/reset-E2E-password branch from a50c420 to e9f037a Compare September 1, 2025 18:54
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 73.77049% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.36%. Comparing base (ccfae1c) to head (52b50e1).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36778      +/-   ##
===========================================
+ Coverage    66.34%   66.36%   +0.02%     
===========================================
  Files         3323     3323              
  Lines       111282   111320      +38     
  Branches     21081    21109      +28     
===========================================
+ Hits         73829    73882      +53     
+ Misses       34764    34756       -8     
+ Partials      2689     2682       -7     
Flag Coverage Δ
e2e 57.74% <94.73%> (+0.07%) ⬆️
e2e-api 35.51% <ø> (-0.01%) ⬇️
unit 71.61% <62.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris added this to the 7.11.0 milestone Sep 1, 2025
@dougfabris dougfabris marked this pull request as ready for review September 1, 2025 21:16
@dougfabris dougfabris requested a review from a team as a code owner September 1, 2025 21:16
@dougfabris dougfabris requested a review from tassoevan September 2, 2025 18:34
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Sep 2, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 2, 2025
@kodiakhq kodiakhq bot merged commit 5af5203 into develop Sep 3, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the feat/reset-E2E-password branch September 3, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants