Skip to content

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Aug 22, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-1322

Copy link
Contributor

dionisio-bot bot commented Aug 22, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 22, 2025

⚠️ No Changeset found

Latest commit: 3cbb9c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yash-rajpal yash-rajpal marked this pull request as ready for review August 22, 2025 14:04
@yash-rajpal yash-rajpal requested review from a team as code owners August 22, 2025 14:04
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.13%. Comparing base (ae48139) to head (3cbb9c2).
⚠️ Report is 12 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36774      +/-   ##
===========================================
+ Coverage    66.07%   66.13%   +0.05%     
===========================================
  Files         3293     3303      +10     
  Lines       110665   110993     +328     
  Branches     20994    21045      +51     
===========================================
+ Hits         73124    73407     +283     
- Misses       34869    34912      +43     
- Partials      2672     2674       +2     
Flag Coverage Δ
e2e 57.31% <100.00%> (+0.01%) ⬆️
unit 71.48% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yash-rajpal yash-rajpal modified the milestones: 7.10.0, 7.11.0 Aug 28, 2025
@yash-rajpal yash-rajpal requested a review from tiagoevanp August 28, 2025 14:19
Copy link
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicaschelly
Copy link
Member

Can you add a description? Both here and on Jira, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants