-
Notifications
You must be signed in to change notification settings - Fork 12.1k
refactor: Custom notification sound from streams #36774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36774 +/- ##
===========================================
+ Coverage 66.07% 66.13% +0.05%
===========================================
Files 3293 3303 +10
Lines 110665 110993 +328
Branches 20994 21045 +51
===========================================
+ Hits 73124 73407 +283
- Misses 34869 34912 +43
- Partials 2672 2674 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you add a description? Both here and on Jira, ty! |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
CORE-1322