Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: GenericModal dismissing strategy #35026

Merged
merged 4 commits into from
Jan 25, 2025
Merged

chore: GenericModal dismissing strategy #35026

merged 4 commits into from
Jan 25, 2025

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jan 24, 2025

Proposed changes (including videos or screenshots)

The change is about skipping some state mutations whenever a GenericModal element is dismissed aiming for React 18 compatibility.

Issue(s)

Related to ARCH-1285

Steps to test or reproduce

Further comments

@tassoevan tassoevan requested a review from a team as a code owner January 24, 2025 00:09
Copy link
Contributor

dionisio-bot bot commented Jan 24, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: 4ccb8e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan added this to the 7.4.0 milestone Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35026/

Built to branch gh-pages at 2025-01-24 21:42 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (492eba9) to head (4ccb8e4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35026      +/-   ##
===========================================
- Coverage    59.17%   59.17%   -0.01%     
===========================================
  Files         2822     2822              
  Lines        68116    68112       -4     
  Branches     15144    15144              
===========================================
- Hits         40310    40306       -4     
  Misses       24975    24975              
  Partials      2831     2831              
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan requested a review from a team as a code owner January 24, 2025 17:02
@tassoevan tassoevan changed the title fix: GenericModal dismissing strategy chore: GenericModal dismissing strategy Jan 24, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jan 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 25, 2025
@ggazzo ggazzo merged commit 3913bd2 into develop Jan 25, 2025
47 of 49 checks passed
@ggazzo ggazzo deleted the fix/modal-dismiss branch January 25, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants