-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: GenericModal
dismissing strategy
#35026
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35026 +/- ##
===========================================
- Coverage 59.17% 59.17% -0.01%
===========================================
Files 2822 2822
Lines 68116 68112 -4
Branches 15144 15144
===========================================
- Hits 40310 40306 -4
Misses 24975 24975
Partials 2831 2831
Flags with carried forward coverage won't be shown. Click here to find out more. |
b563d32
to
ce7e1cf
Compare
ce7e1cf
to
334f7e2
Compare
ba8f1a6
to
fef266f
Compare
GenericModal
dismissing strategyGenericModal
dismissing strategy
Proposed changes (including videos or screenshots)
The change is about skipping some state mutations whenever a
GenericModal
element is dismissed aiming for React 18 compatibility.Issue(s)
Related to ARCH-1285
Steps to test or reproduce
Further comments