-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app actions showing in room toolbar without icon #34839
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 92d2e1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34839 +/- ##
===========================================
- Coverage 59.14% 59.13% -0.01%
===========================================
Files 2821 2821
Lines 67981 67965 -16
Branches 15148 15142 -6
===========================================
- Hits 40208 40193 -15
Misses 24938 24938
+ Partials 2835 2834 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
f99890b
to
9b6a4a1
Compare
Proposed changes (including videos or screenshots)
Apps actions usually don't have an icon.
After removing an item from the omnichannel header toolbar, the limit of 6 items before adding to
Options
menu was resulting in app actions showing on the toolbar without an icon.This PR adds:
before:
after:
Issue(s)
CONN-450
Steps to test or reproduce
Further comments