Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app actions showing in room toolbar without icon #34839

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Dec 27, 2024

Proposed changes (including videos or screenshots)

Apps actions usually don't have an icon.
After removing an item from the omnichannel header toolbar, the limit of 6 items before adding to Options menu was resulting in app actions showing on the toolbar without an icon.
This PR adds:

  • condition to only show app actions inside the menu, even if there are less then 6 items on the toolbar
  • test cover for this case

before:
image

after:
image

Issue(s)

CONN-450

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 27, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 27, 2024

🦋 Changeset detected

Latest commit: 92d2e1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (7839bf0) to head (92d2e1e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34839      +/-   ##
===========================================
- Coverage    59.14%   59.13%   -0.01%     
===========================================
  Files         2821     2821              
  Lines        67981    67965      -16     
  Branches     15148    15142       -6     
===========================================
- Hits         40208    40193      -15     
  Misses       24938    24938              
+ Partials      2835     2834       -1     
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34839/
on branch gh-pages at 2025-01-08 14:13 UTC

@juliajforesti juliajforesti added this to the 7.3.0 milestone Jan 6, 2025
@juliajforesti juliajforesti force-pushed the fix/toolbar-app-items branch from f99890b to 9b6a4a1 Compare January 7, 2025 15:55
@juliajforesti juliajforesti marked this pull request as ready for review January 7, 2025 18:37
@juliajforesti juliajforesti requested a review from a team as a code owner January 7, 2025 18:37
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Jan 8, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 8, 2025
@kodiakhq kodiakhq bot merged commit 1cc2bc7 into develop Jan 8, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/toolbar-app-items branch January 8, 2025 14:48
This was referenced Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants