Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve startup dependencies load #34200

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

ricardogarim
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 17, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 6b897dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ricardogarim ricardogarim force-pushed the chore/startup-dependencies branch from 12ed293 to 13858e2 Compare December 17, 2024 15:43
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34200/
on branch gh-pages at 2024-12-17 15:55 UTC

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 75.78%. Comparing base (7edc3db) to head (6b897dd).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34200      +/-   ##
===========================================
- Coverage    75.83%   75.78%   -0.06%     
===========================================
  Files          511      511              
  Lines        22171    22189      +18     
  Branches      5397     5403       +6     
===========================================
+ Hits         16813    16815       +2     
- Misses        4710     4725      +15     
- Partials       648      649       +1     
Flag Coverage Δ
unit 75.78% <25.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim force-pushed the chore/startup-dependencies branch from 13858e2 to 4086a47 Compare December 17, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant