Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove settings dependency on startup #34199

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Dec 17, 2024

Proposed changes (including videos or screenshots)

The idea is to remove code dependencies to "settings cached" during the startup that are spread everywhere in the codebase. This is basically but not only represented by code using settings in the file's top level scope.

The currently method to make sure the settings cache is built before code is run is importing the "cached settings" from the file that builds the cache, so the top level await will ensure the cache is built before everything else runs. The proposal here is that we don't rely on this mechanism anymore by having a more clear code path, so we first build the cache and after that we import everything else.

So this is the first step of many to come, the changes are basically moving code relying on settings to functions and then calling this functions on the appropriate moment.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 17, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 9d2994f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 17, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34199/
on branch gh-pages at 2024-12-20 17:32 UTC

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (35de31c) to head (9d2994f).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #34199       +/-   ##
============================================
+ Coverage    59.28%   75.27%   +15.98%     
============================================
  Files         2821      516     -2305     
  Lines        67942    22532    -45410     
  Branches     15110     5485     -9625     
============================================
- Hits         40277    16960    -23317     
+ Misses       24833     4911    -19922     
+ Partials      2832      661     -2171     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego force-pushed the remove-settings-deps-on-startup branch from 621797f to 63fef6e Compare December 17, 2024 18:12
@sampaiodiego sampaiodiego changed the title chore: Remove settings dependency on startup refactor: Remove settings dependency on startup Dec 17, 2024
@sampaiodiego sampaiodiego marked this pull request as ready for review December 19, 2024 19:12
@sampaiodiego sampaiodiego requested a review from a team as a code owner December 19, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant