fix: Deletion of 1st message in a thread causes notification to be up without showing why. #34165
+129
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, everytime a message has a tmid(is a thread), and it gets deleted, we decrease the replyCount of the parent message then remove the unread thread unread, to make sure all the subscriptions are up to date (and notify to the client) At the end, we check if the parent message had all of its thread messages deleted, if so, we notify the change in the parent message itself
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 09754f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34165 +/- ##
============================================
+ Coverage 59.28% 75.27% +15.99%
============================================
Files 2820 516 -2304
Lines 67932 22540 -45392
Branches 15102 5485 -9617
============================================
- Hits 40275 16968 -23307
+ Misses 24831 4911 -19920
+ Partials 2826 661 -2165
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
matheusbsilva137
requested changes
Dec 12, 2024
…ify everyone that is on the replies list
matheusbsilva137
requested changes
Dec 13, 2024
KevLehman
requested changes
Dec 13, 2024
MarcosSpessatto
previously approved these changes
Dec 19, 2024
MarcosSpessatto
approved these changes
Dec 19, 2024
Gustrb
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Gustrb
removed
the
stat: QA assured
dionisio-bot
bot
removed
the
stat: ready to merge
Gustrb
added
stat: ready to merge
Gustrb
removed
stat: ready to merge
KevLehman
approved these changes
Dec 20, 2024
matheusbsilva137
approved these changes
Dec 20, 2024
Gustrb
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes the issue that would arise all the times the first (and only) message of a thread would get deleted. What was happening is that, we were not checking, on deletion, if all the messages of a thread had been deleted, which was making the UI feel unresponsive, since the 'Following' bell would show as if there were unread messages even if the message was deleted.
So, now, we do a couple checks to ensure consistency:
Issue(s)
Steps to test or reproduce
You are going to need two users, let's call them user A and B, they both must be at the same room for you to be able to test.
Expected:
Further comments
CONN-261