Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Long Button Text Overflows and Causes Misalignment in User Info #34059

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Rohit-Khairmode
Copy link

Proposed changes

This pull request addresses the issue of long button text overflowing and causing misalignment in the User Info section. The changes include:

  • Increased the width of contextualbarSize
  • Replaced normal Button with IconButton for small screens

Issue(s)

Closes #34043

Steps to test

  1. Open a channel
  2. click to any member username
  3. See full profile

@Rohit-Khairmode Rohit-Khairmode requested a review from a team as a code owner November 26, 2024 13:36
Copy link
Contributor

dionisio-bot bot commented Nov 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 32b78fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rohit-Khairmode Rohit-Khairmode changed the title [FIX] Long Button Text Overflows and Causes Misalignment in User Info (#34043) fix: Long Button Text Overflows and Causes Misalignment in User Info Nov 26, 2024
@thepiyush-303
Copy link
Contributor

Your changes increase the contextualBarSize to accommodate the text, but the same component is also used to display 'Threads,' 'Mentions,' 'Members,' etc. These changes unintentionally affect the size of these components, which is not desirable. Therefore, the proposed changes are not valid in their current form.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long Button Text Overflows and Causes Misalignment in User Info
3 participants