-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: remove query field on dm messages listing #33807
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b7d46ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8018ccc
to
57232fe
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33807 +/- ##
=================================================
- Coverage 75.08% 74.96% -0.13%
=================================================
Files 493 481 -12
Lines 21834 21044 -790
Branches 5458 5339 -119
=================================================
- Hits 16395 15776 -619
+ Misses 4792 4636 -156
+ Partials 647 632 -15
Flags with carried forward coverage won't be shown. Click here to find out more. |
37e7c46
to
d10bdb7
Compare
Proposed changes (including videos or screenshots)
Per CORE-770, this update shifts the
mentions._id
,starred._id
, andpinned
query parameters directly to the root level in GET/api/v1/im.messages
and/api/v1/dm.messages
and removes the query attribute.mentions._id
should now be passed asmentionIds
directly at the root level and supports a comma-separated list of setting IDs (e.g.,mentionIds=foo
ormentionIds=foo,bar
).starred._id
should now be passed asstarredIds
directly at the root level and supports a comma-separated list of setting IDs (e.g.,starredIds=foo
orstarredIds=foo,bar
).pinned
should now be passed directly at the root level as a boolean or string.ALLOW_UNSAFE_QUERY_AND_FIELDS_API_PARAMS
environment variable totrue
when initializing the server.Steps to test or reproduce
Issue(s)
Steps to test or reproduce
Further comments
Note to Mobile Team – Based on im.ts#L68, it looks like
mentions._id
,starred._id
, andpinned
are the attributes needing support. If any other parameters are required, please reach out.