-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(i18n): Use i18next‘s t-function in more modules #33732
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33732 +/- ##
========================================
Coverage 75.56% 75.56%
========================================
Files 491 491
Lines 21533 21533
Branches 5368 5368
========================================
Hits 16271 16271
Misses 4625 4625
Partials 637 637 |
Proposed changes (including videos or screenshots)
It replaces
useTranslation
from@rocket.chat/ui-contexts
withuseTranslation
fromreact-i18next
.Issue(s)
ARCH-1298
Steps to test or reproduce
Further comments
It follows from #33601. Additional care was put to detect
sprintf
-postprocessed translations.