Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(i18n): Use i18next‘s t-function in more modules #33732

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 23, 2024

Proposed changes (including videos or screenshots)

It replaces useTranslation from @rocket.chat/ui-contexts with useTranslation from react-i18next.

Issue(s)

ARCH-1298

Steps to test or reproduce

Further comments

It follows from #33601. Additional care was put to detect sprintf-postprocessed translations.

Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 8286938

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33732/
on branch gh-pages at 2024-10-23 22:09 UTC

@tassoevan tassoevan marked this pull request as ready for review October 23, 2024 23:09
@tassoevan tassoevan requested review from a team as code owners October 23, 2024 23:09
@ggazzo ggazzo added this to the 7.1.0 milestone Oct 24, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 24, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.56%. Comparing base (247b1c6) to head (8286938).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33732   +/-   ##
========================================
  Coverage    75.56%   75.56%           
========================================
  Files          491      491           
  Lines        21533    21533           
  Branches      5368     5368           
========================================
  Hits         16271    16271           
  Misses        4625     4625           
  Partials       637      637           

@ggazzo ggazzo merged commit d8ed08f into develop Oct 24, 2024
54 checks passed
@ggazzo ggazzo deleted the refactor/more-react-i18next branch October 24, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants