Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: voip action button using default instead of secondary variant #33729

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 23, 2024

Proposed changes (including videos or screenshots)

This PR fixes the voip popup buttons using the default variant instead of the secondary variant.

Before:
old-voip-buttons

After:
new-voip-buttons

Issue(s)

VOIP-117

Steps to test or reproduce

  • Access workspace
  • Configure VoIP for team collaboration
  • Start a voice call
  • Buttons should be visible within the popup

Further comments

@aleksandernsilva aleksandernsilva added this to the 7.0 milestone Oct 23, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 1a02483

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva changed the title regression: voip action button using default variant instead of secondary variant regression: voip action button using default instead of secondary variant Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33729/
on branch gh-pages at 2024-10-23 21:36 UTC

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (0649a67) to head (1a02483).
Report is 4 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33729      +/-   ##
=================================================
- Coverage          74.97%   74.97%   -0.01%     
=================================================
  Files                480      480              
  Lines              21019    21018       -1     
  Branches            5334     5333       -1     
=================================================
- Hits               15760    15759       -1     
  Misses              4630     4630              
  Partials             629      629              
Flag Coverage Δ
unit 74.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 24, 2024 00:31
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Oct 24, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 24, 2024
@kodiakhq kodiakhq bot merged commit ccaa315 into release-7.0.0 Oct 24, 2024
53 checks passed
@kodiakhq kodiakhq bot deleted the regression/voip-button-secondary branch October 24, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants