minor changes

Signed-off-by: Abhinav Kumar <[email protected]>
RocketChat · Oct 28, 2024 · 82f9d85 · 82f9d85
1 parent 2a5fdf3
commit 82f9d85
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/apps/meteor/app/emoji-custom/client/lib/emojiCustom.ts b/apps/meteor/app/emoji-custom/client/lib/emojiCustom.ts
@@ -96,7 +96,7 @@ export const updateEmojiCustom = (emojiData: IEmoji) => {
 	}
 
 	if (previousExists) {
-		replaceEmojiInRecent(emojiData.previousName, emojiData.name);
+		replaceEmojiInRecent({ oldEmoji: emojiData.previousName, newEmoji: emojiData.name });
 	}
 };
 

diff --git a/apps/meteor/app/emoji/client/helpers.ts b/apps/meteor/app/emoji/client/helpers.ts
@@ -156,7 +156,7 @@ export const updateRecent = (recentList: string[]) => {
 	});
 };
 
-export const replaceEmojiInRecent = (oldEmoji: string, newEmoji: string) => {
+export const replaceEmojiInRecent = ({ oldEmoji, newEmoji }: { oldEmoji: string; newEmoji: string }) => {
 	const recentPkgList: string[] = emoji.packages.base.emojisByCategory.recent;
 	const pos = recentPkgList.indexOf(oldEmoji);
 

diff --git a/apps/meteor/tests/unit/app/emoji/helpers.spec.ts b/apps/meteor/tests/unit/app/emoji/helpers.spec.ts
@@ -36,15 +36,15 @@ describe('Emoji Client Helpers', () => {
 	describe('replaceEmojiInRecent', () => {
 		it('should replace an existing emoji with a new one in recent emojis', () => {
 			emoji.packages.base.emojisByCategory.recent = ['emoji1', 'emoji2', 'emoji3'];
-			replaceEmojiInRecent('emoji2', 'emoji4');
+			replaceEmojiInRecent({ oldEmoji: 'emoji2', newEmoji: 'emoji4' });
 			expect(emoji.packages.base.emojisByCategory.recent).to.not.include('emoji2');
 			expect(emoji.packages.base.emojisByCategory.recent).to.include('emoji4');
 			expect(emoji.packages.base.emojisByCategory.recent).to.deep.equal(['emoji1', 'emoji4', 'emoji3']);
 		});
 
 		it('should do nothing if the emoji to replace is not in the recent list', () => {
 			emoji.packages.base.emojisByCategory.recent = ['emoji1', 'emoji2'];
-			replaceEmojiInRecent('emoji3', 'emoji4');
+			replaceEmojiInRecent({ oldEmoji: 'emoji3', newEmoji: 'emoji4' });
 			expect(emoji.packages.base.emojisByCategory.recent).to.deep.equal(['emoji1', 'emoji2']);
 		});
 	});