Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Japanese localization #2777

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Haruka319
Copy link

@RocketChat/ios

Hello,
I tried to improve some of the Japanese translations on RocketChat for Hacktoberfest.
I hope it helps the app.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #2777 into develop will decrease coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2777      +/-   ##
===========================================
- Coverage    46.28%   45.32%   -0.96%     
===========================================
  Files          624      624              
  Lines        28881    28881              
===========================================
- Hits         13367    13090     -277     
- Misses       15514    15791     +277
Impacted Files Coverage Δ
Rocket.Chat/Views/Base/BaseNavigationBar.swift 0% <0%> (-100%) ⬇️
Rocket.Chat/Views/Chat/ChatAnnouncementView.swift 0% <0%> (-83.34%) ⬇️
...ontrollers/Chat/MessagesViewControllerTyping.swift 0% <0%> (-77.78%) ⬇️
...ntrollers/Chat/MessagesViewControllerJoining.swift 0% <0%> (-71.74%) ⬇️
...trollers/Chat/MessagesViewControllerDrafting.swift 20% <0%> (-60%) ⬇️
...Views/Cells/Subscription/ChatPreviewModeView.swift 0% <0%> (-43.75%) ⬇️
...Chat/Controllers/Chat/MessagesViewController.swift 1.38% <0%> (-42.86%) ⬇️
...ocket.Chat/Extensions/Models/ObjectExtension.swift 80% <0%> (-20%) ⬇️
...Chat/Models/Mapping/LoginServiceModelMapping.swift 51.68% <0%> (-14.61%) ⬇️
Rocket.Chat/Theme/ThemeableViews.swift 35.19% <0%> (-10.2%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 936f049...daffef0. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants