This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 438
[NEW] Sync deleted messages #2617
Open
luismachado
wants to merge
1
commit into
RocketChat:develop
Choose a base branch
from
luismachado:feature/sync_deleted_messages
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
Rocket.Chat/API/Requests/Room/RoomDeletedMessagesRequest.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// | ||
// RoomDeletedMessagesRequest.swift | ||
// Rocket.Chat | ||
// | ||
// Created by Luís Machado on 29/03/2019. | ||
// Copyright © 2019 Rocket.Chat. All rights reserved. | ||
// | ||
|
||
import SwiftyJSON | ||
import Foundation | ||
|
||
struct RoomDeletedMessagesRequest: APIRequest { | ||
typealias APIResourceType = DeletedMessagesResource | ||
|
||
let path = "/api/v1/chat.getDeletedMessages" | ||
let requiredVersion = Version(0, 73, 0) | ||
|
||
var query: String? | ||
let roomId: String? | ||
let since: Date? | ||
|
||
// How to improve this default date? We only want deleted messages as far as the older message we have on cache! (older ones won't be returned) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Line Length Violation: Line should be 120 characters or less: currently 147 characters (line_length) |
||
init(roomId: String, since: Date = Date(timeIntervalSince1970: 0)) { | ||
self.roomId = roomId | ||
self.since = since | ||
|
||
let dateFormatter = ISO8601DateFormatter() | ||
let dateString = dateFormatter.string(from: since) | ||
|
||
if let encodedString = dateString.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed) { | ||
self.query = "roomId=\(roomId)&since=\(encodedString)" | ||
} | ||
} | ||
} | ||
|
||
final class DeletedMessagesResource: APIResource { | ||
var messages: [String?]? { | ||
return raw?["messages"].arrayValue.map { | ||
if let removedMsg = $0.dictionaryObject, let msgId = removedMsg["_id"] as? String { | ||
return msgId | ||
} | ||
return nil | ||
} | ||
} | ||
|
||
var count: Int? { | ||
return raw?["count"].int | ||
} | ||
|
||
var offset: Int? { | ||
return raw?["offset"].int | ||
} | ||
|
||
var total: Int? { | ||
return raw?["total"].int | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line Length Violation: Line should be 120 characters or less: currently 123 characters (line_length)
Todo Violation: TODOs should be resolved (Save latest date? Older messag...). (todo)