This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[BLOCKED][IMPROVEMENT] Remove markdown & parse emojis in push notifications #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 14, 2018
Rocket.Chat.NotificationServiceExtension/NotificationService.swift
Outdated
Show resolved
Hide resolved
Rocket.Chat.NotificationServiceExtension/NotificationService.swift
Outdated
Show resolved
Hide resolved
Rocket.Chat.NotificationServiceExtension/NotificationService.swift
Outdated
Show resolved
Hide resolved
rafaelks
reviewed
Dec 14, 2018
| @@ -104,6 +104,7 @@ fileprivate extension RCMarkdownParser { | |||
| parser.strikeAttributes = [NSAttributedString.Key.strikethroughStyle.rawValue: NSNumber(value: NSUnderlineStyle.single.rawValue)] | |||
| parser.linkAttributes = [NSAttributedString.Key.foregroundColor.rawValue: UIColor.darkGray] | |||
|
|
|||
| #if !EXCLUDE_MARKDOWN_DOWNLOAD | |||
There was a problem hiding this comment.
I love the idea of using this kind of configuration per scheme, but what about something "pattern", like this?
ROCKETCHAT_MARKDOWN_DOWNLOAD_MEDIA
This way we:
- Make sure the name is actually managed by us;
- It's a positive checking, not negative, will be like this:
#if ROCKETCHAT_MARKDOWN_DOWNLOAD_MEDIA
...
#endifI think it brings more clarity to the code... what do you think?
There was a problem hiding this comment.
- Agreed with namespacing the flag
- If positive then we have to remember to add it for every build configuration in every target :/ this is very specific for the Notification Service Extension to avoid including all our download related classes.
rafaelks
reviewed
Dec 14, 2018
| @@ -308,3 +309,5 @@ public extension UIColor { | |||
| "YELLOWGREEN" : "9ACD32" | |||
| ] | |||
| } | |||
|
|
|||
| // swiftlint:enable all | |||
There was a problem hiding this comment.
I decided to treat this file as an external library. It has tons of single letter variables that prevent compiling with our linter.
Should I rewrite it? What do you think?
houndci-bot
reviewed
Dec 21, 2018
cardoso
changed the title
cardoso
changed the title
cardoso
force-pushed
the
imp/remove_md_pn
branch
from
f1f214b
to
04d0c50
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Had to move some stuff around to share markdown code with the extension
Partially closes #1563
Blocked by RocketChat/Rocket.Chat#12956