feat: enhance a11y experience in room swipe actions#6985
feat: enhance a11y experience in room swipe actions#6985OtavioStasiak wants to merge 3 commits intodevelopfrom
Conversation
WalkthroughThe PR enhances accessibility for the RoomItem component by disabling accessibility on action buttons, adding accessibility hints for long-press interactions, introducing a new module to generate action sheet options, and integrating long-press functionality with screen reader detection to display contextual room actions. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant RoomItemContainer
participant AccessibilityInfo
participant ActionSheet
participant ActionHandlers
User->>RoomItemContainer: Long press
RoomItemContainer->>AccessibilityInfo: isScreenReaderEnabled()
AccessibilityInfo-->>RoomItemContainer: status
alt Screen Reader Enabled
RoomItemContainer->>RoomItemContainer: getRoomActionsOptions()
RoomItemContainer->>ActionSheet: showActionSheet(options)
ActionSheet-->>User: Display actions
User->>ActionSheet: Select action
ActionSheet->>ActionHandlers: Execute (toggleRead/toggleFav/hideRoom)
ActionHandlers-->>User: Action completed
else Screen Reader Disabled
RoomItemContainer->>User: Default behavior or custom handler
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-12-17T15:56:22.578ZApplied to files:
🧬 Code graph analysis (3)app/containers/RoomItem/getRoomActionsOptions.ts (4)
app/containers/RoomItem/index.tsx (3)
app/containers/RoomItem/Wrapper.tsx (1)
🔇 Additional comments (6)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Android Build Available Rocket.Chat Experimental 4.70.0.108278 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRoi4l1ziJFBJAWjXU9e9brk_cIMPE4-4LeplWjsirTk5pbtlhxJLmdJoBCT3KMB92TvLMEcycq39EimBPf |
|
iOS Build Available Rocket.Chat Experimental 4.70.0.108279 |
Proposed changes
Issue(s)
https://rocketchat.atlassian.net/browse/MA-264
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
New Features
Accessibility