Skip to content

feat(Android): Migrate SSLPinning to new arch #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

feat(Android): Migrate SSLPinning to new arch #6627

merged 1 commit into from
Sep 5, 2025

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Sep 4, 2025 •
edited
Loading

Proposed changes

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1005

How to test or reproduce

  • connect and interact on the ssl client certificate workspace

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello temporarily deployed to approve_e2e_testing September 4, 2025 22:21 — with GitHub Actions Inactive
@diegolmello diegolmello temporarily deployed to experimental_ios_build September 4, 2025 22:24 — with GitHub Actions Inactive
@diegolmello diegolmello temporarily deployed to experimental_android_build September 4, 2025 22:24 — with GitHub Actions Inactive
@diegolmello diegolmello marked this pull request as ready for review September 4, 2025 22:24
@diegolmello diegolmello had a problem deploying to upload_experimental_android September 4, 2025 22:51 — with GitHub Actions Error
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025

Android Build Available

Rocket.Chat Experimental 4.64.0.107223

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRmZO8amR1fvO_-wz8jqCwr7iDdZLQCcAG2CNWHDdPu1embnHB1tHj9U0Li8Koh0V6NX_-nqoKPCjHJ1Ehi

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025

iOS Build Available

Rocket.Chat Experimental 4.64.0.107224

OtavioStasiak
OtavioStasiak approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@diegolmello diegolmello force-pushed the feat.ssl-pinning-android-new-arch branch from c685a1f to fb2b564 Compare September 5, 2025 16:57
@diegolmello diegolmello merged commit df7f5fd into develop Sep 5, 2025
4 of 7 checks passed
@diegolmello diegolmello deleted the feat.ssl-pinning-android-new-arch branch September 5, 2025 16:57
@diegolmello diegolmello requested a deployment to experimental_android_build September 5, 2025 16:59 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to official_android_build September 5, 2025 16:59 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to experimental_ios_build September 5, 2025 16:59 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OtavioStasiak OtavioStasiak OtavioStasiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegolmello @OtavioStasiak