Skip to content

Conversation

Rohit3523
Copy link
Collaborator

@Rohit3523 Rohit3523 commented Sep 2, 2025

Proposed changes

This pull request

  • introduced e2e-encryption test
  • fix for join-from-directory, I created a new channel with name 'join-from-directory' which is unique right now, 'detox-public' channel sometimes not appear in search
  • improve test for logout

Working action link: https://github.com/RocketChat/Rocket.Chat.ReactNative/actions/runs/17590432988

Important: 2 tests are failing on iOS and i will fix it later because we want to get tests working but they are working on Android right now

Test failing on iOS:
Screenshot 2025-09-10 at 6 45 25 PM

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-967

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@Rohit3523
Copy link
Collaborator Author

Please disable new arch before testing

@diegolmello diegolmello temporarily deployed to approve_e2e_testing September 10, 2025 14:08 — with GitHub Actions Inactive
@diegolmello diegolmello requested a deployment to official_android_build September 10, 2025 14:10 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to experimental_android_build September 10, 2025 14:10 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to experimental_ios_build September 10, 2025 14:10 — with GitHub Actions Waiting
@diegolmello diegolmello merged commit 28f4436 into develop Sep 10, 2025
8 of 17 checks passed
@diegolmello diegolmello deleted the test-e2e branch September 10, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants