Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Add support to Linebreak and Katex on markdown #4361

Merged
merged 11 commits into from
Jul 20, 2022
Merged

[IMPROVE] Add support to Linebreak and Katex on markdown #4361

merged 11 commits into from
Jul 20, 2022

Conversation

dnlsilva
Copy link
Contributor

@dnlsilva dnlsilva commented Jul 13, 2022 •
edited by diegolmello
Loading

Proposed changes

Fixes the issue of texts in markdown not skipping lines when the component is Code, and the spacing when having a line break.
Add KaTeX support.

Issue(s)

Closes #1973

How to test or reproduce

  • View any message with spacing or inline code.
  • Test KaTeX text.
    Send this message to other user:
\[ f(x) = \int_{-\infty}^\infty \hat f(\xi)\,e^{2 \pi i \xi x} \,d\xi \]

Screenshots

Before:
Screen Shot 2022-07-13 at 09 55 05

After:
Screen Shot 2022-07-13 at 09 54 45

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Inline KaTeX is currently not supported due to parse issues, however there is an open issue:
RocketChat/fuselage#775

@dnlsilva dnlsilva changed the title [IMPROVE] Add LineBreak markdown component and fixes Code markdown component [IMPROVE] Add LineBreak and fixes Code on markdown component ++ Add KaTeX support Jul 13, 2022
diegolmello
diegolmello requested changes Jul 14, 2022
View reviewed changes
app/containers/markdown/new/Katex.tsx Outdated Show resolved Hide resolved
app/containers/markdown/new/Katex.tsx Outdated Show resolved Hide resolved
app/containers/markdown/new/Katex.tsx Show resolved Hide resolved
@diegolmello diegolmello changed the title [IMPROVE] Add LineBreak and fixes Code on markdown component ++ Add KaTeX support [IMPROVE] Add support to Linebreak and Katex on markdown Jul 18, 2022
@dnlsilva dnlsilva merged commit 376c8e8 into develop Jul 20, 2022
@dnlsilva dnlsilva deleted the fix-new-markdown branch July 20, 2022 21:02
diegolmello pushed a commit that referenced this pull request Sep 12, 2022
@dnlsilva @diegolmello
[IMPROVE] Add support to Linebreak and Katex on markdown (#4361)
6716d06 
* fix enableMessageParser logic

* create LineBreak component

* fix code style

* add KaTeX support

* add Katex and Inline Katex stories

* update snapshots

* add color prop

* update snapshot

* update snapshot
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@dnlsilva
[IMPROVE] Add support to Linebreak and Katex on markdown (RocketChat#…
c8c21a3 
…4361)

* fix enableMessageParser logic

* create LineBreak component

* fix code style

* add KaTeX support

* add Katex and Inline Katex stories

* update snapshots

* add color prop

* update snapshot

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEW] KaTeX Support
2 participants
@dnlsilva @diegolmello