This repository was archived by the owner on Jun 30, 2022. It is now read-only.
Allow setGuestName and setGuestEmail to update inputs#627
Open
hanoii wants to merge 2 commits intoRocketChat:developfrom
Open
Allow setGuestName and setGuestEmail to update inputs#627hanoii wants to merge 2 commits intoRocketChat:developfrom
hanoii wants to merge 2 commits intoRocketChat:developfrom
Conversation
Contributor
Author
|
I actually found a problem here, while adding this the internal state is always overwritten to the default (could be empty) even while typing something new, thus not triggering validations or anything. I noticed this in particular as I am working in both this and #628 |
Contributor
Author
|
I improved this considerably, I think. I noticed a bunch of different issues with how different usecases around setting up name and email:
After reading on
I refactored a bit how the props to state were copied as were as handled. Doing most on the constructor and handling default changed by set* functions on |
|
Please merge this. It has been an issue for long now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #626