This repository was archived by the owner on Jun 30, 2022. It is now read-only.
[FIX] Only first trigger working #232#537
Open
etlam wants to merge 2 commits intoRocketChat:developfrom
Open
Conversation
Only the first trigger of type page-url was working. Requests got deleted before checking the second trigger.
|
|
Contributor
|
@etlam Hi dude, thanks for your PR, I'm trying to test your implementation but still receiving only the first trigger message, could you test again? Also, please sync merging the |
Author
|
@rafaelblink How did you test the behaviour? |
Contributor
|
Unfortunately the bug is a bit deeper than just changing this variable, I've started a branch to work on this issue, here it is: https://github.com/RocketChat/Rocket.Chat.Livechat/tree/fix/broken-triggers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the first trigger of type page-url was working. Requests got deleted before checking the second trigger.
Closes #232