This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 552
[WIP][NEW] Group same user messages #2299
Open
Adizbek
wants to merge
10
commits into
RocketChat:develop
Choose a base branch
from
Adizbek:group-avatars-new
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipbrito
reviewed
May 14, 2019
app/src/main/java/chat/rocket/android/chatroom/adapter/MessageViewHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatroom/adapter/MessageViewHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatroom/adapter/MessageViewHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatroom/adapter/MessageViewHolder.kt
Outdated
Show resolved
Hide resolved
@filipedelimabrito I have fixed all issues which you listed above. |
Is not it good to consider it when the alias is different? |
@jungeonkim Yes, you're right. I have fixed. Now code looks better. |
@Adizbek Is it still a WIP? |
@filipedelimabrito The only last part remained, As said in issue #712
I couldn't find how to realize it, currently it is manually set to 900sec. |
Something all stopped |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/android
Closes #712
As describe in issue:
Some criteria not implemented yet.
Screenshots or GIF for the change:
https://youtu.be/3ciV8ZmTaE0