Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[WIP][NEW] Show media size #2213

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Adizbek
Copy link
Contributor

@Adizbek Adizbek commented Apr 9, 2019

@RocketChat/android

UI improvement

  • Audio size
  • Video size
  • File size
  • Image size

Changes: Show media size in message.

Screenshots or GIF for the change:

image
image

@Adizbek
Copy link
Contributor Author

Adizbek commented Apr 9, 2019

Снимок экрана 2019-04-09 в 18 20 21

There is not field which represents file size. @filipedelimabrito, is that implemented in server side?

Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow our coding style (there are indentation issues here.)

@Adizbek Adizbek changed the title Show media size [WIP] Show media size Apr 27, 2019
@Adizbek
Copy link
Contributor Author

Adizbek commented May 3, 2019

https://github.com/RocketChat/Rocket.Chat.Kotlin.SDK/blob/ebeaa66c8d557ef869ed9c2b6a488b63f1972c97/core/src/main/kotlin/chat/rocket/core/model/attachment/Attachment.kt#L7-L36

@filipedelimabrito, I search docs but not found anything. Is there any field which represents attached file size.
In kotlin SDK, I found Attachment data class, I think it's missed to add fileSize field.

@philipbrito philipbrito changed the title [WIP] Show media size [WIP][NEW] Show media size May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants