Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hideAvatar and added actionsMessage #761

Closed

Conversation

thepiyush-303
Copy link

@thepiyush-303 thepiyush-303 commented Dec 30, 2024

Brief Title

Acceptance Criteria fulfillment

  • Hide Avatar on pinned/quoted messages.
  • add actions messages.

Fixes #760

Video/Screenshots

image

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@abirc8010
Copy link
Contributor

abirc8010 commented Dec 30, 2024

Hey @thepiyush-303 about the action messages part , I have covered it in my PR #746.
It’s always a good idea to check if there’s an existing issue or PR to avoid duplication, although it’s understandable that we might miss it sometimes. 🙂

Also I can see the quoted message is not rendered , I think you can try passing attachment directly to the Markdown instead of attachment.text

@Spiral-Memory
Copy link
Collaborator

Hey @thepiyush-303
I didn't really get, why we need to hide avatar ?
n what action message you are talking about here..

Pls make a video in the PR or in the issue explaining in more detail.

@abirc8010
Copy link
Contributor

Hi @Spiral-Memory, regarding the action messages, you can refer to my issue #745. I've also submitted PR #746 related to it.

@Spiral-Memory
Copy link
Collaborator

I think @abirc8010 has already raised a pr on that, any specific reason, why i am seeing duplicated issues and PR ?

@Spiral-Memory
Copy link
Collaborator

I think, its safe to close this PR
Maybe for hiding the user icon, @thepiyush-303 you can raise another PR, if you can justify the reason, why we are hiding that

@thepiyush-303
Copy link
Author

thepiyush-303 commented Jan 1, 2025

@Spiral-Memory
I didn't see that issue is alreday been raised i will be more careful in future
and regarding hiding user-avatar:
when user chooses to hide avatar it hides message header avatar but pinned msgs and quoted messages avatar didn't hide that's what i mean to.
Screencast from 2025-01-01 18-47-57.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some actions messages missing and hideAvatar doesnot hide pinned or quoted avatars
3 participants