-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: image gallery showing error #759
Conversation
Hey, this used to work perfectly before, is it something related to new rocket.chat version or something related to room / channel permissions. Can you pls look into it in more depth, try connecting with different channel and see, how it responds. |
@devanshkansagra, as you have multiple version of RC, i believe, maybe try to have a collaboration on this issue |
Hey @Spiral-Memory, lots of issues come when there is a new version of rocket.chat released. Yesterday the similar thing I have discussed with @SinghaAnirban005 regarding that pin permissions to different roles issue and that editing permissions issue whose prs got merged in recent code reviews. And by this I concluded with him we have to come up with the dynamic and optimal solutions for these kind of issues. |
@Spiral-Memory @devanshkansagra |
Let's try to make EmbeddedChat consistent with the latest stable release of rocket.chat atleast and then some other stable prev Rocket.Chat versions.. |
Should I merge this ? |
Hey @Spiral-Memory, if this pr according to the latest stable version then you can go for merging it and also I don't think so that rocketchat will modify this api endpoint in their next few stable releases also, so you can go for merging it |
Brief Title
Fixed image rendering issue in gallery
Acceptance Criteria fulfillment
channels.images
torooms.images
.Fixes #758
Video/Screenshots
Screencast.from.2024-12-30.22-36-56.webm
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-759 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.