Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display bio, nickname, and statusText in User Info modal; resolve permission issues for viewing full user info #756

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

SinghaAnirban005
Copy link
Contributor

@SinghaAnirban005 SinghaAnirban005 commented Dec 29, 2024

Brief Title

Fix User Info Modal Issues and Permission Handling

Acceptance Criteria fulfillment

  • Ensure bio, nickname, and statusText are displayed in the User Info modal when set.
  • Allow normal users to view the username and statusText of other users.
  • Fix permission logic to allow normal users to access full user information when granted by admin.

Fixes #755

Video/Screenshots

EmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2024-12-30.01-07-40.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-756 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

…e permission issues for viewing full user info
Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spiral-Memory Spiral-Memory merged commit 21d6f2d into RocketChat:develop Jan 1, 2025
4 checks passed
github-actions bot added a commit that referenced this pull request Jan 1, 2025
SinghaAnirban005 added a commit to SinghaAnirban005/EmbeddedChat that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants