Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added Tooltip for Jump to msg button #751

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dhairyashiil
Copy link
Contributor

@dhairyashiil dhairyashiil commented Dec 29, 2024

Acceptance Criteria fulfillment

  • After pointing the mouse at the Send button icon, the user should see the text "Send Message".
  • After pointing the mouse at the Arrow-back button in the Starred Messages and Pinned Messages sidebar, the user should see the text "Go To Message".

Fixes #750

Screenshots

Send Button:

image

Starred Messages:

image

Pinned Messages:

image

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-751 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

"Send Message" -> A tooltip for send icon is unnecessary, pls remove that.

For the Go to Message, change it to Jump to Message, Let's be consistent with Rocket.Chat channel terminologies

@Spiral-Memory Spiral-Memory changed the title Feat: Added Tooltip for Send button & Arrow-back button Feat: Added Tooltip for Jump to msg button Jan 1, 2025
@dhairyashiil
Copy link
Contributor Author

Hello @Spiral-Memory,
I’ve updated it to "Jump to message." From now on, I will follow Rocket.Chat channel’s terminologies. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add Tooltip For Jump to Msg Button
2 participants