chore: video modal responsiveness #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work @abirc8010 |
|
@Spiral-Memory I have made it occupy the entire display as you suggested. |
Spiral-Memory
approved these changes
Jan 5, 2025
|
Hey @abirc8010 |
|
@Spiral-Memory I made the required changes |
|
Can you update the video bro |
|
@Spiral-Memory I updated the video. |
| @@ -112,6 +112,14 @@ export const getCommonRecorderStyles = (theme) => { | |||
| display: flex; | |||
| margin: auto; | |||
| `, | |||
| modal: { | |||
| '@media(max-width: 500px)': { | |||
There was a problem hiding this comment.
Can you please use a standard width here ? Maybe 768 pixels
Spiral-Memory
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
Fix video modal responsiveness
Acceptance Criteria fulfillment
Fixes #725
Video/Screenshots
Screencast.from.2025-01-11.21-54-45.webm
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-726 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.