Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: The 'Copy' option functionality is now working for File messages #716

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dhairyashiil
Copy link
Contributor

Brief Title

The 'Copy' option functionality is now working for File messages

Acceptance Criteria fulfillment

  • 'Copy' option copying the respective File description
  • If the File description is not present then a popup appears saying 'No message or attachment description available to copy'

Fixes #715

Video/Screenshots

Fix.copy.to.clipboard.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-716 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Maybe, let's follow the same design pattern as RC
It shows copy icon, and simply copies the file name in case of text not present..
Once look into it and revise accordingly

@dhairyashiil
Copy link
Contributor Author

Maybe, let's follow the same design pattern as RC It shows copy icon, and simply copies the file name in case of text not present.. Once look into it and revise accordingly

Yes, Working on it

@dhairyashiil
Copy link
Contributor Author

Refer this:

  1. If the file description is present -> copy the file description
  2. If the file description is not present -> copy the file name ((same for audio and video messages))
Save.Message.Functionality.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: 'Copy' option functionality is not working for File messages
2 participants