Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Quoting issues #641

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

devanshkansagra
Copy link
Contributor

@devanshkansagra devanshkansagra commented Oct 23, 2024

Acceptance Criteria fulfillment

  • Recursively Quoting of messages
  • Multiple quoting of messages

Fixes #640

Video/Screenshots

Screencast.from.04-11-24.10.14.00.PM.IST.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval.

@devanshkansagra devanshkansagra marked this pull request as ready for review November 4, 2024 17:04
@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, I have implemented recursive and multiple quoting in EmbeddedChat, can you please review it?

@devanshkansagra
Copy link
Contributor Author

Let me know once you check the deployment of this pull request

@Spiral-Memory
Copy link
Collaborator

Sure @devanshkansagra

@devanshkansagra
Copy link
Contributor Author

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Message quoting issues
2 participants