added a feature of quick create from the input box itself.. #23

not-meet · 2024-11-22T05:30:14Z

Issue(s)

Closes #22

##This PR introduces a new feature that allows users to create quick replies directly from the message input box using the /quick create command, eliminating the need for an input modal.

Acceptance Criteria fulfillment

Introduce support for the /quick create command format.
Validate inputs directly within the command execution handler.
Notify users about the success or failure of reply creation via in-app notifications.

Proposed changes (including videos or screenshots)

Users can now create quick replies with the following format:
/quick create
Ensures the command includes at least a name (replyName) and a body (replyBody).
Displays an error message if the inputs are invalid or missing.
New File for Quick Reply Logic: Contains the logic for handling /quick create.
Updates to CommandUtility.ts: Added logic to check the input arguments. Redirects the call to the appropriate handler based on the input.

Demo

Screencast from 2024-11-22 10-32-50.webm

up for any changes and learning :)

CLAassistant · 2024-11-22T05:30:19Z

All committers have signed the CLA.

VipinDevelops

There is alot of thing's that make no sense, try to make a PR that is clear and not bloated it, Ideally a PR should not have move then 200-300 line of code.

VipinDevelops · 2024-11-22T06:15:39Z

src/commands/CommandUtility.ts

-	IModify,
-	IPersistence,
-	IRead,
+    IHttp,


remove these spaces

VipinDevelops · 2024-11-22T06:15:47Z

src/commands/CommandUtility.ts

-	public persis: IPersistence;
-	public triggerId?: string;
-	public threadId?: string;
+    public app: QuickRepliesApp;


VipinDevelops · 2024-11-22T06:16:46Z

src/commands/CommandUtility.ts

+                const subCommand = this.params[0].toLowerCase();
+
+                if (
+                    subCommand === CommandParam.CREATE ||


why are we creating team in all the command ? explain me this

VipinDevelops · 2024-11-22T06:17:00Z

src/commands/CommandUtility.ts

+                await this.handleSingleParam(handler);
+                break;
+            }
+            default: {


this should not be in default

VipinDevelops · 2024-11-22T06:17:28Z

src/commands/CommandUtility.ts

+            }
+        }
+    }
+    private async handleQuickCreate(handler: Handler, args: string[]): Promise<void> {


we already handled default cases

VipinDevelops · 2024-11-22T06:18:30Z

src/modal/quickCommands/createquick.ts

+    );
+
+    if (args.length < 3) {
+        await sendUsageMessage(modify, room, sender);


what is this ?

VipinDevelops · 2024-11-22T06:18:45Z

src/handlers/Handler.ts

-			return;
-		}
-	}
+    public app: QuickRepliesApp;


too much bloated code remove all these spaces

VipinDevelops · 2024-11-22T06:19:12Z

src/modal/quickCommands/createquick.ts

+    room: IRoom,
+    user: IUser,
+): Promise<void> {
+    const text = '/quick-create <replyName> "<replyBody>"';


why we have this code ?

VipinDevelops

Make requested changes

not-meet · 2024-11-22T12:34:38Z

Hi @VipinDevelops so i reflected the changes you asked for and made them as per the requirements

Note
the reason of adding the handlequickcreate function in the default is because of the number of arguments and the authentication of the keyword used as the switch case works on the parameters of length so as there can be a high chances of having uncertainty of inputs ive added quick create function in the default as it gets only called when there is a create keyword in the first index! :)

VipinDevelops

There is still a lot of room for improvement basically you are repeating a lot of code and not following best practice.

VipinDevelops · 2024-11-23T15:27:38Z

src/commands/CommandUtility.ts

@@ -77,7 +77,13 @@ export class CommandUtility implements ICommandUtility {
 				break;
 			}
 			default: {
-				await handler.sendDefault();
+				const subCommand = this.params[0].toLowerCase();


you don't have to put this in switch case you can handle this in global

VipinDevelops · 2024-11-23T15:28:25Z

src/commands/CommandUtility.ts

@@ -107,4 +113,23 @@ export class CommandUtility implements ICommandUtility {
 			}
 		}
 	}
+
+	private async handleQuickCreate(handler: Handler, args: string[]): Promise<void> {


why dont use the function we already have for creating new replies ?

VipinDevelops · 2024-11-23T15:28:47Z

src/commands/CommandUtility.ts

+		  return;
+		}
+
+		switch (args[0].toLowerCase()) {


why switch case in a function that is made to create a reply ?

VipinDevelops · 2024-11-23T15:29:49Z

src/commands/CommandUtility.ts

+			await handler.CreateQuickReply(args);
+			break;
+		  }
+		  default: {


this is the third place where you please .sendDefault() is there any other way to achieve check without repeating this

VipinDevelops · 2024-11-23T15:30:09Z

src/handlers/Handler.ts

@@ -206,4 +207,20 @@ export class Handler implements IHandler {
 			return;
 		}
 	}
+	public async CreateQuickReply(args: string[]): Promise<void> {


we do have a method already for this

VipinDevelops · 2024-11-23T15:33:29Z

Also, update the documentation accordingly.

…e best practice

not-meet · 2024-11-30T15:16:56Z

hey @VipinDevelops made changes as you asked..! now i believe the code looks much cleaner to be merged...
up if there are any other changes to be made : )

VipinDevelops · 2024-12-16T18:17:50Z

Hey @not-meet Can you explain a little about changes you have made and use the code we have already for creating replies I have seen you writing some code again that already exist Either reuse the function we have or make something new that can be use in both old and new code.

not-meet · 2024-12-17T08:56:57Z

hey!! @VipinDevelops
so I've added conditional logic in the CreateModal to take the reply name and body from CLI arguments as the original modal uses the input from the input boxes in the modal.

I wrote new logic instead of modifying the existing modal to avoid conflicts. While I understand the concern about calling the handler in the default switch case instead of passing it globally, doing so avoids issues where the global call still triggers the switch case unintentionally.

VipinDevelops reviewed Nov 22, 2024

View reviewed changes

VipinDevelops requested changes Nov 22, 2024

View reviewed changes

not-meet force-pushed the quickcreatereplies branch from 9612a78 to db79d2c Compare November 22, 2024 12:30

not-meet requested a review from VipinDevelops November 22, 2024 12:35

VipinDevelops reviewed Nov 23, 2024

View reviewed changes

made changes in the pr as per the comments removed unused code for th…

7d8d7b0

…e best practice

not-meet force-pushed the quickcreatereplies branch from db79d2c to 7d8d7b0 Compare November 30, 2024 15:04

not-meet added 2 commits November 30, 2024 20:41

removed linting commits

1a58780

removed comments

cca74eb

not-meet requested a review from VipinDevelops November 30, 2024 15:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added a feature of quick create from the input box itself.. #23

added a feature of quick create from the input box itself.. #23

not-meet commented Nov 22, 2024 •

edited

Loading

CLAassistant commented Nov 22, 2024 •

edited

Loading

VipinDevelops left a comment

VipinDevelops Nov 22, 2024

VipinDevelops Nov 22, 2024

VipinDevelops Nov 22, 2024

VipinDevelops Nov 22, 2024

VipinDevelops Nov 22, 2024

VipinDevelops Nov 22, 2024

VipinDevelops Nov 22, 2024

VipinDevelops Nov 22, 2024

VipinDevelops left a comment

not-meet commented Nov 22, 2024 •

edited

Loading

VipinDevelops left a comment

VipinDevelops Nov 23, 2024

VipinDevelops Nov 23, 2024

VipinDevelops Nov 23, 2024

VipinDevelops Nov 23, 2024

VipinDevelops Nov 23, 2024

VipinDevelops commented Nov 23, 2024

not-meet commented Nov 30, 2024

VipinDevelops commented Dec 16, 2024 •

edited

Loading

not-meet commented Dec 17, 2024 •

edited

Loading

added a feature of quick create from the input box itself.. #23

Are you sure you want to change the base?

added a feature of quick create from the input box itself.. #23

Conversation

not-meet commented Nov 22, 2024 • edited Loading

Issue(s)

Acceptance Criteria fulfillment

Proposed changes (including videos or screenshots)

Demo

CLAassistant commented Nov 22, 2024 • edited Loading

VipinDevelops left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VipinDevelops left a comment

Choose a reason for hiding this comment

not-meet commented Nov 22, 2024 • edited Loading

VipinDevelops left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VipinDevelops commented Nov 23, 2024

not-meet commented Nov 30, 2024

VipinDevelops commented Dec 16, 2024 • edited Loading

not-meet commented Dec 17, 2024 • edited Loading

not-meet commented Nov 22, 2024 •

edited

Loading

CLAassistant commented Nov 22, 2024 •

edited

Loading

not-meet commented Nov 22, 2024 •

edited

Loading

VipinDevelops commented Dec 16, 2024 •

edited

Loading

not-meet commented Dec 17, 2024 •

edited

Loading