Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO] Connect gameplay to new is_done() in planner #1913

Open
kfu02 opened this issue Jun 26, 2022 · 0 comments
Open

[TODO] Connect gameplay to new is_done() in planner #1913

kfu02 opened this issue Jun 26, 2022 · 0 comments
Assignees
@kfu02
Labels
area / AI area / planning-motion exp / legendary (∞) priority / high pull request todo From a TODO in code

Comments

@kfu02
Copy link
Contributor

kfu02 commented Jun 26, 2022 •
edited
Loading

Pull request: #1911

Link to TODO, or file number/line: path_target_planner.cpp:line 61

The is_done() methods in gameplay are not connected to the is_done() calls in the planner, so there is essentially a worse version of the same code in gameplay.

Gameplay should be connected to planner is_dones to avoid this weird quirk (which may involve more gameplay changes than I'd like).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfu02 kfu02

Labels
area / AI area / planning-motion exp / legendary (∞) priority / high pull request todo From a TODO in code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kfu02