Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Node 23 #327

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Testing Node 23 #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64d3759
Testing against Node 23
RobinTail Nov 4, 2024
8fa3ce5
temp: allowing node 23 for testing purposes
RobinTail Nov 4, 2024
d9a4041
CI: ignore engines for install command
RobinTail Nov 4, 2024
4a892db
ignoring engines for comapatibility test
RobinTail Nov 4, 2024
8dd958d
fix command for compat test
RobinTail Nov 4, 2024
ba2736e
Merge branch 'main' into test-node-23
RobinTail Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.18.0, 18.x, 20.9.0, 20.x, 22.0.0, 22.x]
node-version: [18.18.0, 18.x, 20.9.0, 20.x, 22.0.0, 22.x, 23.1.0, 23.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
steps:
- name: Get yarn cache dir
Expand All @@ -34,7 +34,7 @@ jobs:
path: ${{ steps.yarnCache.outputs.dir }}
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ matrix.node-version }}-${{ hashFiles('**/yarn.lock') }}
- name: Install dependencies
run: yarn install
run: yarn install --ignore-engines
- name: Lint
run: yarn lint
- name: Unit test
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"*.md"
],
"engines": {
"node": "^18.18.0 || ^20.9.0 || ^22.0.0"
"node": "^18.18.0 || ^20.9.0 || ^22.0.0 || ^23.0.0"
},
"author": {
"name": "Anna Bocharova",
Expand All @@ -42,7 +42,7 @@
"posttest": "make-coverage-badge --output-path coverage.svg",
"test:cjs": "yarn --cwd tests/cjs && vitest run -r tests/cjs",
"test:esm": "yarn --cwd tests/esm && vitest run -r tests/esm",
"test:compat": "yarn --cwd tests/compat && vitest run -r tests/compat",
"test:compat": "yarn --cwd tests/compat --ignore-engines && vitest run -r tests/compat",
"test:952": "yarn --cwd tests/issue952 && yarn --cwd tests/issue952 test",
"test:system": "yarn --cwd tests/system && vitest run -r tests/system",
"mdfix": "prettier *.md --write",
Expand Down
Loading